This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Qa integration #762
Merged
Qa integration #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- Added directive for adding banners just like empty state -- Added TCO 16 banner data
-- Fixed lint errors
-- Fixed lint errors
Add View my submissions button to progress bar modal
AS:100624428182393, Create a modified Dashboard banner for TCO
-- Fixed padding for non desktop layouts.
AS:100624428182393, Create a modified Dashboard banner for TCO
Add member search
Add vic's changes - new image, not upper case title
-- Increased supported length to 15 from 3 for TLD
AS#101110714058011, User cannot add custom URL to profile
…oder-app into qa-integration
dev to qa
-- Adapted banner directive to show HTML inside description field -- Added TTL banner
AS#111130683709862, Topcoder Team Live banner (for Friday broadcast)
Newrelic errors
Contributor
|
@nlitwin I think we are good to go. Most of the changes are changes from $log to logger and some code formatting. Apart from that I have glanced over my changes which seems fine to me and I think the major changes you made is regarding member search and that too has its majority of changes in topcoder-app-r repo, in this repo we have only few files to integrate it with the app-r. 👍 |
Contributor
Author
|
Thanks Vikas! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vikasrohit @parthshah Hey all, I'm a little nervous to make this PR to production, since it's so huge and has several features (banners, member search, logger update, etc.). Could you guys take a brief look and let me know if it seems safe to merge? So far, dev and QA seem ok